[DSpace-CRIS] Inverse Relations via Authority Framework (Frontend)#5134
[DSpace-CRIS] Inverse Relations via Authority Framework (Frontend)#5134FrancescoMolinaro wants to merge 5 commits intoDSpace:mainfrom
Conversation
…old module import
tdonohue
added
new feature
DSpace-CRIS merger
|
@FrancescoMolinaro : Could you specify which DSpace-CRIS differences this PR relates to? I think it's important to be clear to reviewers which features or architectural changes are in each PR, and it's unclear to me which one(s) this references |
|
Hi @FrancescoMolinaro, |
|
@FrancescoMolinaro : This appears to require backend PR DSpace/DSpace#11963 , so I've updated the description to note that |
tdonohue
changed the title
KevinVdV
left a comment
KevinVdV
left a comment
There was a problem hiding this comment.
I made an initial review of this PR, I found 2 small issues, see details below.
Issue 1
The backend add support for the following pages to make use of this search box:
- people
- org units
- projects,
But in the PR the only place theds-authority-related-entities-searchis used is in the person entity.
Issue 2
The new authority framework UI component is enabled by default, this will cause with backwards compatibility. Can you modify the configuration so that the authority framework is optional (so it is the same as in the REST code)
github-project-automation
bot
moved this from 🙋 Needs Reviewers Assigned
to 👀 Under Review
in DSpace 10.0 Release
|
Hi @KevinVdV , thanks for the feedback, I have updated the item pages so that also OrgUnit and Projects have their configurations as on the backend. |
3 participants
References
Description
Add new component for tabbed relations in item page.
The new relations are based on a scope parameter which represent the authority of the item in question.
Visually the component still uses the standard search page and is identical:
The new relations can be activated via a flag param in the default.app.config.ts, inside the item config:
showAuthorithyRelations
if true the ui components will use the new authority based relations.
Instructions for Reviewers
List of changes in this PR:
Add new UI component for new scope/authority based relations
Include guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintnpm run check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.